linux-kernel - Re: [PATCH 1/2] drivers/misc/eeprom/men_eeprod: Introduce MEN Board Information EEPROM driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141016085835.GA1273@katana>
Date:	Thu, 16 Oct 2014 10:58:35 +0200
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Andreas Werner <andreas.werner@....de>
Cc:	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	linux-i2c@...r.kernel.org, johannes.thumshirn@....de
Subject: Re: [PATCH 1/2] drivers/misc/eeprom/men_eeprod: Introduce MEN Board
 Information EEPROM driver

On Thu, Oct 16, 2014 at 10:15:08AM +0200, Andreas Werner wrote:
> Added driver to support the MEN Board Information EEPROM.
> The driver exports the production information as read only sysfs
> entries, as well as a user section which is read/write accessible.
> 
> Tested on PPC QorIQ and Intel Atom E680.
> 
> Tested-by: Johannes Thumshirn <johannes.thumshirn@....de>
> Signed-off-by: Andreas Werner <andreas.werner@....de>

I guess this is just a standard EEPROM with a well defined layout?
Why don't you want to use the standard driver then and parse the thing
in userspace?

Consider how bloated the sysfs-ABI might get if every vendor who uses an
eeprom wants to expose the data this way?

> +struct eeprom_data {
> +	uint8_t eeprod_id;
> +
> +	uint8_t revision[3];
> +	uint32_t serialnr;
> +	uint8_t board_model;
> +	char hw_name[6];
> +
> +	uint8_t reserved;
> +
> +	__be16 prod_date;
> +	__be16 rep_date;
> +
> +	uint8_t reserved2[4];
> +};

And what if the compiler reorders?


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)