linux-kernel - Re: [PATCH] kernel:module Fix coding style errors and warnings.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1413452333.6702.1.camel@perches.com>
Date:	Thu, 16 Oct 2014 02:38:53 -0700
From:	Joe Perches <joe@...ches.com>
To:	Ionut Alexa <ionut.m.alexa@...il.com>
Cc:	rusty@...tcorp.com.au, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kernel:module Fix coding style errors and warnings.

On Thu, 2014-10-16 at 12:36 +0300, Ionut Alexa wrote:
> Fixed codin style errors and warnings. Changes printk with
> print_debug/warn. Changed seq_printf to seq_puts.

If you are going to do style cleanups, please make
sure you check your patches with scripts/checkpatch.pl
before sending them.

WARNING: missing space after struct definition
#104: FILE: kernel/module.c:743:
+struct stopref{

WARNING: line over 80 characters
#190: FILE: kernel/module.c:1550:
+			error = sysfs_create_file(&mod->mkobj.kobj, &temp_attr->attr);

total: 0 errors, 2 warnings, 187 lines checked

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/