lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20141016173456.GA4357@saruman>
Date:	Thu, 16 Oct 2014 12:34:56 -0500
From:	Felipe Balbi <balbi@...com>
To:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
CC:	Alan Stern <stern@...land.harvard.edu>,
	Felipe Balbi <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] USB: OHCI: ohci-at91: remove unnecessary headers

On Thu, Oct 16, 2014 at 05:52:38PM +0200, Alexandre Belloni wrote:
> Remove unnecessary mach/* headers to be able to converge to a multiplatform
> kernel.
> 
> Signed-off-by: Alexandre Belloni <alexandre.belloni@...e-electrons.com>

Very nice

Reviewed-by: Felipe Balbi <balbi@...com>

> ---
>  drivers/usb/host/ohci-at91.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c
> index e49eb4f90f5d..6181549883af 100644
> --- a/drivers/usb/host/ohci-at91.c
> +++ b/drivers/usb/host/ohci-at91.c
> @@ -24,12 +24,8 @@
>  #include <linux/usb.h>
>  #include <linux/usb/hcd.h>
>  
> -#include <mach/hardware.h>
>  #include <asm/gpio.h>
>  
> -#include <mach/cpu.h>
> -
> -
>  #include "ohci.h"
>  
>  #define valid_port(index)	((index) >= 0 && (index) < AT91_MAX_USBH_PORTS)
> -- 
> 1.9.1
> 

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ