linux-kernel - Re: [PATCH v2] clk: rockchip: rk3288: i2s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5441807.rM669MWZMA@phil>
Date:	Thu, 16 Oct 2014 21:17:06 +0200
From:	Heiko Stübner <heiko@...ech.de>
To:	Jianqun <jay.xu@...k-chips.com>
Cc:	mturquette@...aro.org, dianders@...omium.org,
	kever.yang@...k-chips.com, dbasehore@...omium.org,
	mark.yao@...k-chips.com, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, huangtao@...k-chips.com,
	cf@...k-chips.com
Subject: Re: [PATCH v2] clk: rockchip: rk3288: i2s_frac adds flag to set parent's rate

Hi Jianqun,

Am Montag, 13. Oktober 2014, 08:44:16 schrieb Jianqun:
> The relation of i2s nodes as follows:
>           i2s_src               1           1            594000000  0
>              i2s_frac           1           1            11289600   0
>                 i2s_pre         1           1            11289600   0
>                    sclk_i2s0    1           1            11289600   0
>                    i2s0_clkout  0           0            11289600   0
>                       hclk_i2s0 1           1            148500000  0
> 
> "sclk_i2s0" is the master clock, should allow to set its parent's rate.
> Add flag CLK_SET_RATE_PARENT for "i2s_frac", "i2s_pre" and "sclk_i2s0".
> 
> Tested on rk3288 board using max98090, with command "aplay <music.wav>"
> and cat /sys/kernel/debug/clk/clk_summary |grep i2s
> 
> Signed-off-by: Jianqun <jay.xu@...k-chips.com>

It looks like this is already in the mainline kernel [0].

It seems like I didn't catch the "Change-Id" at the time, and it is the 
variant where i2s_clkout can set the parent rates.

Could you do a follow-up patch removing the CLK_SET_RATE_PARENT from 
i2s_clkout again please?


Thanks
Heiko

[0] 
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=fc69ed70c16a31d6a77ec47a30a9fe941f763f1e

> ---
> change since v1:
> - no "Change-Id"s in upstream patches, suggested by Heiko
> - to limit i2s0_clkout to select between its two parent without being able
>   influence the core i2s clock, suggested by Heiko
> 
>  drivers/clk/rockchip/clk-rk3288.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/clk/rockchip/clk-rk3288.c
> b/drivers/clk/rockchip/clk-rk3288.c index b22a2d2..ae32d78 100644
> --- a/drivers/clk/rockchip/clk-rk3288.c
> +++ b/drivers/clk/rockchip/clk-rk3288.c
> @@ -238,15 +238,15 @@ static struct rockchip_clk_branch
> rk3288_clk_branches[] __initdata = { COMPOSITE(0, "i2s_src",
> mux_pll_src_cpll_gpll_p, 0,
>  			RK3288_CLKSEL_CON(4), 15, 1, MFLAGS, 0, 7, DFLAGS,
>  			RK3288_CLKGATE_CON(4), 1, GFLAGS),
> -	COMPOSITE_FRAC(0, "i2s_frac", "i2s_src", 0,
> +	COMPOSITE_FRAC(0, "i2s_frac", "i2s_src", CLK_SET_RATE_PARENT,
>  			RK3288_CLKSEL_CON(8), 0,
>  			RK3288_CLKGATE_CON(4), 2, GFLAGS),
> -	MUX(0, "i2s_pre", mux_i2s_pre_p, 0,
> +	MUX(0, "i2s_pre", mux_i2s_pre_p, CLK_SET_RATE_PARENT,
>  			RK3288_CLKSEL_CON(4), 8, 2, MFLAGS),
>  	COMPOSITE_NODIV(0, "i2s0_clkout", mux_i2s_clkout_p, 0,
>  			RK3288_CLKSEL_CON(4), 12, 1, MFLAGS,
>  			RK3288_CLKGATE_CON(4), 0, GFLAGS),
> -	GATE(SCLK_I2S0, "sclk_i2s0", "i2s_pre", 0,
> +	GATE(SCLK_I2S0, "sclk_i2s0", "i2s_pre", CLK_SET_RATE_PARENT,
>  			RK3288_CLKGATE_CON(4), 3, GFLAGS),
> 
>  	MUX(0, "spdif_src", mux_pll_src_cpll_gpll_p, 0,

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/