linux-kernel - Re: [PATCH 03/12] [media] V4L2: mx3_camer: use dmaengine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.1410162140390.16927@axis700.grange>
Date:	Thu, 16 Oct 2014 21:40:57 +0200 (CEST)
From:	Guennadi Liakhovetski <g.liakhovetski@....de>
To:	Vinod Koul <vinod.koul@...el.com>
cc:	dmaengine@...r.kernel.org,
	Mauro Carvalho Chehab <m.chehab@...sung.com>,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 03/12] [media] V4L2: mx3_camer: use dmaengine_pause()
 API

On Sat, 11 Oct 2014, Vinod Koul wrote:

> The drivers should use dmaengine_pause() API instead of
> accessing the device_control which will be deprecated soon
> 
> Signed-off-by: Vinod Koul <vinod.koul@...el.com>

Acked-by: Guennadi Liakhovetski <g.liakhovetski@....de>

Thanks
Guennadi

> ---
>  drivers/media/platform/soc_camera/mx3_camera.c |    6 ++----
>  1 files changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/media/platform/soc_camera/mx3_camera.c b/drivers/media/platform/soc_camera/mx3_camera.c
> index 83315df..7696a87 100644
> --- a/drivers/media/platform/soc_camera/mx3_camera.c
> +++ b/drivers/media/platform/soc_camera/mx3_camera.c
> @@ -415,10 +415,8 @@ static void mx3_stop_streaming(struct vb2_queue *q)
>  	struct mx3_camera_buffer *buf, *tmp;
>  	unsigned long flags;
>  
> -	if (ichan) {
> -		struct dma_chan *chan = &ichan->dma_chan;
> -		chan->device->device_control(chan, DMA_PAUSE, 0);
> -	}
> +	if (ichan)
> +		dmaengine_pause(&ichan->dma_chan);
>  
>  	spin_lock_irqsave(&mx3_cam->lock, flags);
>  
> -- 
> 1.7.0.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/