linux-kernel - Re: [PATCH] spi/atmel: fix simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5440DBE8.90207@atmel.com>
Date:	Fri, 17 Oct 2014 11:05:44 +0200
From:	Nicolas Ferre <nicolas.ferre@...el.com>
To:	Fengguang Wu <fengguang.wu@...el.com>,
	Mark Brown <broonie@...nel.org>
CC:	<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-spi@...r.kernel.org>, Wenyou Yang <wenyou.yang@...el.com>
Subject: Re: [PATCH] spi/atmel: fix simple_return.cocci warnings

On 16/10/2014 18:18, Fengguang Wu :
> drivers/spi/spi-atmel.c:1518:1-4: WARNING: end returns can be simpified and declaration on line 1514 can be dropped
> 
>  Simplify a trivial if-return sequence.  Possibly combine with a
>  preceding function call.
> Generated by: scripts/coccinelle/misc/simple_return.cocci
> 
> CC: Wenyou Yang <wenyou.yang@...el.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
> ---
> 
> Please take the patch only if it's a positive warning. Thanks!
> 
>  spi-atmel.c |    7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> --- a/drivers/spi/spi-atmel.c
> +++ b/drivers/spi/spi-atmel.c
> @@ -1511,15 +1511,10 @@ static int atmel_spi_runtime_resume(stru
>  {
>  	struct spi_master *master = dev_get_drvdata(dev);
>  	struct atmel_spi *as = spi_master_get_devdata(master);
> -	int ret;
>  
>  	pinctrl_pm_select_default_state(dev);
>  
> -	ret = clk_prepare_enable(as->clk);
> -	if (ret)
> -		return ret;
> -
> -	return 0;
> +	return clk_prepare_enable(as->clk);

Indeed:

Acked-by: Nicolas Ferre <nicolas.ferre@...el.com>

>  }
>  #endif
>  
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 


-- 
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/