[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20141017101734.GB1820@sirena.org.uk>
Date: Fri, 17 Oct 2014 12:17:34 +0200
From: Mark Brown <broonie@...nel.org>
To: Gyungoh Yoo <gyungoh@...il.com>
Cc: sameo@...ux.intel.com, lee.jones@...aro.org, jg1.han@...sung.com,
cooloney@...il.com, lgirdwood@...il.com, jack.yoo@...worksinc.com,
linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
grant.likely@...aro.org, robh+dt@...nel.org, mark.rutland@....com,
ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
pawel.moll@....com, heiko@...ech.de, jason@...edaemon.net,
shawn.guo@...escale.com, treding@...dia.com,
florian.vaussard@...l.ch, trivial@...nel.org, linux@...ck-us.net,
andrew@...n.ch, jic23@...nel.org
Subject: Re: [RESUBMIT PATCH v4 7/8] regulator: sky81452: Add compatible
string for device binding
On Fri, Oct 17, 2014 at 06:19:50PM +0900, Gyungoh Yoo wrote:
> Wow. I understand.
> I missed .supply_name. I think I need something like
> below, before devm_regulator_register().
> config->supply_name = init_data->constraints.name;
> I will resubmit it.
No, not supply_name (though you really should be initializing that
anyway) and you definitely don't want to set supply_name to something
from constraints. The supply_name should be the name of the input pin
that supplies power to the regulator. I was referring to of_match and
regulators_node.
Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)
Powered by blists - more mailing lists