linux-kernel - Re: [PATCH v2 5/7] regulator: max77802: Document regulator opmode DT properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141017115701.GE1820@sirena.org.uk>
Date:	Fri, 17 Oct 2014 13:57:01 +0200
From:	Mark Brown <broonie@...nel.org>
To:	Javier Martinez Canillas <javier.martinez@...labora.co.uk>
Cc:	Lee Jones <lee.jones@...aro.org>,
	Doug Anderson <dianders@...omium.org>,
	Chanwoo Choi <cw00.choi@...sung.com>,
	Olof Johansson <olof@...om.net>,
	Chris Zhong <zyw@...k-chips.com>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Abhilash Kesavan <kesavan.abhilash@...il.com>,
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org
Subject: Re: [PATCH v2 5/7] regulator: max77802: Document regulator opmode DT
 properties

On Thu, Oct 16, 2014 at 06:48:51PM +0200, Javier Martinez Canillas wrote:

> +- maxim,regulator-initial-mode: initial operating mode.
> +  This property can only be used on regulators that support changing their mode
> +  during normal operation. These regulators are LDO1, LDO3, LDO20 and LDO21.
> +- maxim,regulator-disk-mode: operating mode for the regulator when the system
> +  enters in the Suspend-to-Disk state.
> +- maxim,regulator-mem-mode: operating mode for the regulator when the system
> +  enters in the Suspend-to-RAM state.

This seems pretty ugly since it's not integrated with the suspend state
binding at all - adding new suspend modes is going to involve changing
the binding which seems icky.  Adding a standard property to set modes
doesn't seem so bad, I think a translation function to parse device
specific mode bindings in properties might be the way forwards.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)