linux-kernel - Re: [PATCH v2 12/16] usb: dwc3: add delay phy power change quirk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141017145606.GH26260@saruman>
Date:	Fri, 17 Oct 2014 09:56:06 -0500
From:	Felipe Balbi <balbi@...com>
To:	Huang Rui <ray.huang@....com>
CC:	Felipe Balbi <balbi@...com>,
	Alan Stern <stern@...land.harvard.edu>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Paul Zimmerman <Paul.Zimmerman@...opsys.com>,
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	Vincent Wan <vincent.wan@....com>, Tony Li <tony.li@....com>,
	<linux-usb@...r.kernel.org>, <linux-pci@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 12/16] usb: dwc3: add delay phy power change quirk

Hi,

On Fri, Oct 17, 2014 at 04:53:37PM +0800, Huang Rui wrote:
> AMD NL needs to delay PHY power change from P0 to P1/P2/P3 when link state
> changing from U0 to U1/U2/U3 respectively.
> 
> Signed-off-by: Huang Rui <ray.huang@....com>
> ---
>  drivers/usb/dwc3/core.c          | 3 +++
>  drivers/usb/dwc3/core.h          | 1 +
>  drivers/usb/dwc3/dwc3-pci.c      | 3 ++-
>  drivers/usb/dwc3/platform_data.h | 1 +
>  4 files changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> index a9f1d4c..920a8ab 100644
> --- a/drivers/usb/dwc3/core.c
> +++ b/drivers/usb/dwc3/core.c
> @@ -383,6 +383,9 @@ static void dwc3_phy_setup(struct dwc3 *dwc)
>  	if (dwc->quirks & DWC3_QUIRK_DEPP1P2P3)
>  		reg |= DWC3_GUSB3PIPECTL_DEP1P2P3(1);
>  
> +	if (dwc->quirks & DWC3_QUIRK_DEPOCHANGE)

	if (dwc->delay_p0_change_quirk)

> diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c
> index 23ae6a7..0eb8b2a 100644
> --- a/drivers/usb/dwc3/dwc3-pci.c
> +++ b/drivers/usb/dwc3/dwc3-pci.c
> @@ -153,7 +153,8 @@ static int dwc3_pci_probe(struct pci_dev *pci,
>  			| DWC3_QUIRK_U2EXIT_LFPS
>  			| DWC3_QUIRK_U2SSINP3OK
>  			| DWC3_QUIRK_REQP1P2P3
> -			| DWC3_QUIRK_DEPP1P2P3;
> +			| DWC3_QUIRK_DEPP1P2P3
> +			| DWC3_QUIRK_DEPOCHANGE;

combined with the last patch

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)