linux-kernel - Re: [PATCH v3 1/2] usb: dwc2: gadget: sparse warning of context imbalance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141017185209.GY26260@saruman>
Date:	Fri, 17 Oct 2014 13:52:09 -0500
From:	Felipe Balbi <balbi@...com>
To:	Paul Zimmerman <Paul.Zimmerman@...opsys.com>
CC:	Sudip Mukherjee <sudipm.mukherjee@...il.com>,
	"balbi@...com" <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 1/2] usb: dwc2: gadget: sparse warning of context
 imbalance

On Fri, Oct 17, 2014 at 06:50:19PM +0000, Paul Zimmerman wrote:
> > From: Sudip Mukherjee [mailto:sudipm.mukherjee@...il.com]
> > Sent: Thursday, October 16, 2014 9:44 PM
> > 
> > sparse was giving the following warning:
> >         warning: context imbalance in 's3c_hsotg_ep_enable'
> > 	                - different lock contexts for basic block
> > 
> > we were returning ENOMEM while still holding the spinlock.
> > The sparse warning was fixed by releasing the spinlock before return.
> > 
> > Signed-off-by: Sudip Mukherjee <sudip@...torindia.org>
> > ---
> >  drivers/usb/dwc2/gadget.c | 7 +++++--
> >  1 file changed, 5 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
> > index 7b5856f..7f25527 100644
> > --- a/drivers/usb/dwc2/gadget.c
> > +++ b/drivers/usb/dwc2/gadget.c
> > @@ -2561,8 +2561,10 @@ static int s3c_hsotg_ep_enable(struct usb_ep *ep,
> >  			hs_ep->fifo_size = val;
> >  			break;
> >  		}
> > -		if (i == 8)
> > -			return -ENOMEM;
> > +		if (i == 8) {
> > +			ret = -ENOMEM;
> > +			goto error;
> > +		}
> >  	}
> > 
> >  	/* for non control endpoints, set PID to D0 */
> > @@ -2579,6 +2581,7 @@ static int s3c_hsotg_ep_enable(struct usb_ep *ep,
> >  	/* enable the endpoint interrupt */
> >  	s3c_hsotg_ctrl_epint(hsotg, index, dir_in, 1);
> > 
> > +error:
> >  	spin_unlock_irqrestore(&hsotg->lock, flags);
> >  	return ret;
> >  }
> 
> Acked-by: Paul Zimmerman <paulz@...opsys.com>

v3.18-rc or v3.19 ?

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)