linux-kernel - Re: [PATCH 1/4 linux-next] x86, msr: define msr chunksize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54417AC7.7050605@zytor.com>
Date:	Fri, 17 Oct 2014 13:23:35 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Fabian Frederick <fabf@...net.be>, linux-kernel@...r.kernel.org
CC:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, x86@...nel.org
Subject: Re: [PATCH 1/4 linux-next] x86, msr: define msr chunksize

On 10/17/2014 01:01 PM, Fabian Frederick wrote:
> define MSR_CHUNK_SIZE instead of hard-coded value (8).
> 
> Signed-off-by: Fabian Frederick <fabf@...net.be>

I don't like the name, as it isn't a "chunk" but the actual width of an MSR.

Furthermore, the last hunk is just plain wrong; the 8 there refers to
the number of registers and not to the width of an MSR.

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/