linux-kernel - Re: [PATCH 3/3] rheap: move rheap.c from arch/powerpc/lib/ to lib/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <57D1E2E0-077A-4CBE-8534-5B9EE5C81BAE@kernel.crashing.org>
Date:	Fri, 17 Oct 2014 09:53:55 +0200
From:	Kumar Gala <galak@...nel.crashing.org>
To:	Zhao Qiang <B45475@...escale.com>
Cc:	linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>,
	linux-kernel@...r.kernel.org, B07421@...escale.com,
	R63061@...escale.com, pantelis.antoniou@...il.com
Subject: Re: [PATCH 3/3] rheap: move rheap.c from arch/powerpc/lib/ to lib/


On Sep 25, 2014, at 4:47 AM, Zhao Qiang <B45475@...escale.com> wrote:

> qe need to use the rheap, so move it to public directory.
> 
> Signed-off-by: Zhao Qiang <B45475@...escale.com>
> ---
> arch/powerpc/Kconfig                                    | 3 ---
> arch/powerpc/include/asm/fsl_85xx_cache_sram.h          | 2 +-
> arch/powerpc/lib/Makefile                               | 2 --
> arch/powerpc/platforms/44x/Kconfig                      | 2 +-
> arch/powerpc/platforms/85xx/Kconfig                     | 2 +-
> arch/powerpc/platforms/Kconfig                          | 2 +-
> arch/powerpc/platforms/Kconfig.cputype                  | 2 +-
> arch/powerpc/sysdev/cpm1.c                              | 2 +-
> arch/powerpc/sysdev/cpm2.c                              | 2 +-
> arch/powerpc/sysdev/cpm_common.c                        | 2 +-
> arch/powerpc/sysdev/ppc4xx_ocm.c                        | 2 +-
> drivers/dma/bestcomm/Kconfig                            | 2 +-
> drivers/soc/qe/Kconfig                                  | 2 +-
> drivers/soc/qe/qe.c                                     | 2 +-
> drivers/soc/qe/qe_common.c                              | 2 +-
> drivers/video/Kconfig                                   | 2 +-
> include/linux/fsl/bestcomm/sram.h                       | 2 +-
> {arch/powerpc/include/asm => include/linux/fsl}/rheap.h | 0
> lib/Kconfig                                             | 3 +++
> lib/Makefile                                            | 2 ++
> {arch/powerpc/lib => lib}/rheap.c                       | 2 +-
> 21 files changed, 21 insertions(+), 21 deletions(-)
> rename {arch/powerpc/include/asm => include/linux/fsl}/rheap.h (100%)
> rename {arch/powerpc/lib => lib}/rheap.c (99%)

Have you guys looked at moving to lib/genalloc.c.  If we are going to keep rheap around the include should be just in include/linux/rheap.h not include/linux/fsl/rheap.h

However, I think genalloc should be used and kill off rheap usage.

- k--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/