linux-kernel - Re: [RFC PATCH v8] tpm_tis: verify interrupt during init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1410192003420.1938@localhost.localdomain>
Date:	Sun, 19 Oct 2014 20:08:07 +0000 (UTC)
From:	Scot Doyle <lkml14@...tdoyle.com>
To:	Peter Hüwe <PeterHuewe@....de>
cc:	Ashley Lai <ashley@...leylai.com>,
	Marcel Selhorst <tpmdd@...horst.net>,
	Jason Gunthorpe <jgunthorpe@...idianresearch.com>,
	Stefan Berger <stefanb@...ux.vnet.ibm.com>,
	Luigi Semenzato <semenzato@...gle.com>,
	tpmdd-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH v8] tpm_tis: verify interrupt during init

On Mon, 22 Sep 2014, Peter Hüwe wrote:

> Am Montag, 22. September 2014, 19:13:38 schrieb Jason Gunthorpe:
> 
> > 
> > This does look much nicer, lets use this version.
> > 
> > I think Peter were prefer a new clean patch that superceeds the
> > original.
> > 
> > > +	if (!priv->irq_tested) {
> > 
> > I think the sleep and check is still needed here, the IRQ delivery
> > could race relative to the MMIO read of completion, a sleep is the
> > only way we could attempt to synchronize them..
> > 
> 
> So will there be a v9?
> 
> Merge Window is coming up shortly, so I would like to have this sorted out 
> soon ;)
> 
> Thanks,
> Peter

Hi Peter,

The v10 patch was reviewed by Jason and is ready to go. Will you be asking 
James to pull this week?

Thanks,
Scot