linux-kernel - Re: [RFC PATCH 1/8] iio: dummy: Introduce virtual registers for dummy device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 19 Oct 2014 23:39:18 +0300
From:	Daniel Baluta <daniel.baluta@...el.com>
To:	Hartmut Knaack <knaack.h@....de>
Cc:	Daniel Baluta <daniel.baluta@...el.com>,
	Jonathan Cameron <jic23@...nel.org>, linux-iio@...r.kernel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	irina.tirdea@...el.com
Subject: Re: [RFC PATCH 1/8] iio: dummy: Introduce virtual registers for dummy device

On Sun, Oct 19, 2014 at 11:30 PM, Hartmut Knaack <knaack.h@....de> wrote:
> Daniel Baluta schrieb am 02.10.2014 15:43:
>> We need a way to store events generated by iio_dummy_evgen module,
>> in order to correctly process IRQs in iio_simple_dummy_events.
>>
>> For the moment, we add two registers:
>>
>> * id_reg  - ID register, stores the source of the event
>> * id_data - DATA register, stores the type of the event
>>
>> e.g echo 4 > /sys/bus/iio/devices/iio_evgen/poke2
>>
>> id_reg 0x02, id_data 0x04
>>
>> This means, event of type 4 was generated by fake device 2.
>>
>> We currently use a hardcoded mapping of virtual events to IIO events.
>>
>> Signed-off-by: Daniel Baluta <daniel.baluta@...el.com>
>> Signed-off-by: Irina Tirdea <irina.tirdea@...el.com>
>> ---
>>  drivers/staging/iio/iio_dummy_evgen.c         | 16 ++++++++++++++++
>>  drivers/staging/iio/iio_dummy_evgen.h         |  7 +++++++
>>  drivers/staging/iio/iio_simple_dummy.h        |  2 ++
>>  drivers/staging/iio/iio_simple_dummy_events.c | 23 ++++++++++++++++++-----
>>  4 files changed, 43 insertions(+), 5 deletions(-)
>>
> <...>
>> @@ -153,6 +161,14 @@ static ssize_t iio_evgen_poke(struct device *dev,
>>                             size_t len)
>>  {
>>       struct iio_dev_attr *this_attr = to_iio_dev_attr(attr);
>> +     unsigned long event, ret;
> int ret

Good catch. Will fix in v3.

Daniel.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/