linux-kernel - Re: [PATCH resend] [media] rc-core: fix protocol_change regression in ir_raw_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACraW2o3A2vr-a+_47=tL22uUP8h+M5-aGb5Vdq5xsQekN1waQ@mail.gmail.com>
Date:	Sun, 19 Oct 2014 13:14:11 +0300
From:	Tomas Melin <tomas.melin@....fi>
To:	Mauro Carvalho Chehab <m.chehab@...sung.com>
Cc:	james.hogan@...tec.com,
	Antti Seppälä <a.seppala@...il.com>,
	linux-media@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	David Härdeman <david@...deman.nu>
Subject: Re: [PATCH resend] [media] rc-core: fix protocol_change regression in ir_raw_event_register

On Sat, Oct 18, 2014 at 9:18 PM, Mauro Carvalho Chehab
<m.chehab@...sung.com> wrote:
>
> The right behavior here is to enable the protocol as soon as the
> new keycode table is written by userspace.
>
> Except for LIRC and the protocol of the current table enabled is
> not a good idea because:
>
>         1) It misread the code from some other IR;
>         2) It will be just spending power without need, running
>            several tasks (one for each IR type) with no reason, as the
>            keytable won't match the codes for other IRs (and if it is
>            currently matching, then this is a bad behavior).
>
I agree, it sounds overkill to have all protocols enabled by default.
I'll make a new patch that enables lirc but disables other protocols
during registration.

Tomas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/