linux-kernel - Re: [PATCH 1/2] binfmt_misc: add comments & debug logs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1413765718.7076.3.camel@perches.com>
Date:	Sun, 19 Oct 2014 17:41:58 -0700
From:	Joe Perches <joe@...ches.com>
To:	Mike Frysinger <vapier@...too.org>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Al Viro <viro@...iv.linux.org.uk>,
	linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 1/2] binfmt_misc: add comments & debug logs

On Sun, 2014-10-19 at 19:03 -0400, Mike Frysinger wrote:
> let's deploy extensive pr_debug markers at
> logical parse points, and add comments to the dense parsing logic.
[]
> diff --git a/fs/binfmt_misc.c b/fs/binfmt_misc.c
[]
> @@ -259,14 +270,17 @@ static char * check_special_flags (char * sfs, Node * e)
>  	while (cont) {
>  		switch (*p) {
>  			case 'P':
> +				pr_debug("register: flag: P (preserve argv0)");

Missing '\n' newline.
Can you please add them as appropriate?

>  				p++;
>  				e->flags |= MISC_FMT_PRESERVE_ARGV0;
>  				break;
>  			case 'O':
> +				pr_debug("register: flag: O (open binary)");

etc...

> @@ -292,6 +306,8 @@ static Node *create_entry(const char __user *buffer, size_t count)
>  	char *buf, *p;
>  	char del;
>  
> +	pr_debug("register: received %zu bytes", count);

etc...



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/