linux-kernel - Re: [PATCH v2 1/3] ARM: zynq: Move common.h to generic location

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3225036.9QQDRKvzZS@wuerfel>
Date:	Mon, 20 Oct 2014 15:36:06 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	linux-arm-kernel@...ts.infradead.org
Cc:	Michal Simek <michal.simek@...inx.com>,
	Josh Cartwright <josh.cartwright@...com>, monstr@...str.eu,
	Russell King <linux@....linux.org.uk>,
	Peter Crosthwaite <peter.crosthwaite@...inx.com>,
	linux-kernel@...r.kernel.org,
	Steffen Trumtrar <s.trumtrar@...gutronix.de>
Subject: Re: [PATCH v2 1/3] ARM: zynq: Move common.h to generic location

On Monday 20 October 2014 15:25:31 Michal Simek wrote:
> include/soc/zynq/ is the right location for this header
> to be able to share information from this header with other
> drivers which require it.
> 
> Signed-off-by: Michal Simek <michal.simek@...inx.com>
> ---
> 
> Changes in v2:
> - Update pm.c added in 3.17 too - Soren pointed on it
> 
>  arch/arm/mach-zynq/common.c                       |  2 +-
>  arch/arm/mach-zynq/hotplug.c                      | 14 --------------
>  arch/arm/mach-zynq/platsmp.c                      |  2 +-
>  arch/arm/mach-zynq/pm.c                           |  2 +-
>  arch/arm/mach-zynq/slcr.c                         |  2 +-
>  {arch/arm/mach-zynq => include/soc/zynq}/common.h |  0
>  6 files changed, 4 insertions(+), 18 deletions(-)
>  delete mode 100644 arch/arm/mach-zynq/hotplug.c
>  rename {arch/arm/mach-zynq => include/soc/zynq}/common.h (100%)
> 

NAK

Most (if not all) of that header should not be visible to drivers.
If you need to share some symbols, make a proper header file for those,
not one called 'common.h'.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/