| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <54453589.50507@nod.at> Date: Mon, 20 Oct 2014 18:17:13 +0200 From: Richard Weinberger <richard@....at> To: dedekind1@...il.com CC: linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 3/4] UBI: Fastmap: Care about the protection queue Am 20.10.2014 um 18:09 schrieb Artem Bityutskiy: > On Mon, 2014-10-20 at 17:59 +0200, Richard Weinberger wrote: >>> Also, say, PEB X is in the work queue waiting for erasure. Fastmap comes >>> along and saves it as "must be erased" in the fastmap. Fastmap finishes >>> its job, PEB X gets erased, and I write my data there, so PEB X is >>> referred to by LEB Y. Now I have power cut. Then I attach the flash >>> again. Surely it is not that fastmap just erases PEB X and I lose the >>> contents of LEB Y? >> >> This cannot happen. If X is erased you cannot write data do it. I must first go >> thought the pool and the pool is scanned while attaching. > > Just noticed from the code that we first add PEBs to the erase list, and > then we go an scan the pools. In the attach code, yes. But this does not matter. It cannot happen that a fastmap is written with a PEB being in a pool and the erase job list. If you figure out such a state, please tell me. I'll fix it. :-) Thanks, //richard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists