| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20141020181755.GA5851@krava.brq.redhat.com> Date: Mon, 20 Oct 2014 20:17:55 +0200 From: Jiri Olsa <jolsa@...hat.com> To: Andi Kleen <andi@...stfloor.org> Cc: linux-kernel@...r.kernel.org, namhyung@...nel.org, acme@...nel.org, Andi Kleen <ak@...ux.intel.com> Subject: Re: [PATCH 5/8] perf, tools: Support source line numbers in annotate On Mon, Oct 20, 2014 at 08:06:05PM +0200, Jiri Olsa wrote: SNIP > > + if (dl->line_nr && annotate_browser__opts.show_linenr) > > + printed = scnprintf(bf, sizeof(bf), "%*s %-5d ", > > + ab->addr_width, " ", dl->line_nr); > > + else > > + printed = scnprintf(bf, sizeof(bf), "%*s ", > > ab->addr_width, " "); > > slsmg_write_nstring(bf, printed); > > slsmg_write_nstring(dl->line, width - printed - pcnt_width + 1); > > @@ -733,6 +738,7 @@ static int annotate_browser__run(struct annotate_browser *browser, > > "o Toggle disassembler output/simplified view\n" > > "s Toggle source code view\n" > > "/ Search string\n" > > + "k Toggle line numbers\n" > > extra tab --------^^^^^^ making the text misaligned in the help box also by pressing 'k' the current line jumps to the hottest line, which does not seem right jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists