linux-kernel - Re: [PATCH 8/8] tools, perf: Add asprintf replacement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdUdSK=ibgLowJcsduWykcfS7JacHO8wOcYb0hMLtKCwpQ@mail.gmail.com>
Date:	Mon, 20 Oct 2014 21:13:58 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Andi Kleen <andi@...stfloor.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	namhyung@...nel.org, acme@...nel.org,
	Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 8/8] tools, perf: Add asprintf replacement

On Mon, Oct 20, 2014 at 8:28 PM, Jiri Olsa <jolsa@...hat.com> wrote:
>> +int vasprintf(char **str, const char *fmt, va_list ap)
>> +{
>> +     char buf[1024];
>
> could you please make it work for generic buf len?

The actual size above doesn't matter, except for stack usage.
It could be 1 (are there any bugs triggered when using zero? ;-).
The real buffer is allocated by malloc() below.

>> +     int len = vsnprintf(buf, sizeof buf, fmt, ap);
>
> WARNING: sizeof buf should be sizeof(buf)
>
>> +
>> +     *str = malloc(len + 1);
>> +     if (!*str)
>> +             return -1;
>> +     strcpy(*str, buf);
>> +     return len;
>> +}

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/