linux-kernel - Re: [PATCH v2 08/16] usb: dwc3: add u2exit lfps quirk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141020064331.GC24357@hr-slim.amd.com>
Date:	Mon, 20 Oct 2014 14:43:31 +0800
From:	Huang Rui <ray.huang@....com>
To:	Felipe Balbi <balbi@...com>
CC:	Alan Stern <stern@...land.harvard.edu>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Paul Zimmerman" <Paul.Zimmerman@...opsys.com>,
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	Vincent Wan <vincent.wan@....com>, Tony Li <tony.li@....com>,
	<linux-usb@...r.kernel.org>, <linux-pci@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 08/16] usb: dwc3: add u2exit lfps quirk

On Fri, Oct 17, 2014 at 09:50:00AM -0500, Felipe Balbi wrote:
> Hi,
> 
> On Fri, Oct 17, 2014 at 04:53:33PM +0800, Huang Rui wrote:
> > AMD NL needs to enable u2exit lfps quirk.
> > 
> > Signed-off-by: Huang Rui <ray.huang@....com>
> > ---
> >  drivers/usb/dwc3/core.c          | 4 ++++
> >  drivers/usb/dwc3/core.h          | 1 +
> >  drivers/usb/dwc3/dwc3-pci.c      | 3 ++-
> >  drivers/usb/dwc3/platform_data.h | 1 +
> >  4 files changed, 8 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> > index 25db533..7322d85 100644
> > --- a/drivers/usb/dwc3/core.c
> > +++ b/drivers/usb/dwc3/core.c
> > @@ -467,6 +467,10 @@ static int dwc3_core_init(struct dwc3 *dwc)
> >  		reg |= DWC3_GCTL_DISSCRAMBLE;
> >  	else
> >  		reg &= ~DWC3_GCTL_DISSCRAMBLE;
> > +
> > +	if (dwc->quirks & DWC3_QUIRK_U2EXIT_LFPS)
> 
> this should be:
> 
> 	if (dwc->u2_exit_lfps_quirk)
> 

OK, will update it in V3.

> > +		reg |= DWC3_GCTL_U2EXIT_LFPS;
> > +
> >  	/*
> >  	 * WORKAROUND: DWC3 revisions <1.90a have a bug
> >  	 * where the device can fail to connect at SuperSpeed
> > diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
> > index d58479e..3d27f10 100644
> > --- a/drivers/usb/dwc3/core.h
> > +++ b/drivers/usb/dwc3/core.h
> > @@ -166,6 +166,7 @@
> >  #define DWC3_GCTL_SCALEDOWN(n)		((n) << 4)
> >  #define DWC3_GCTL_SCALEDOWN_MASK	DWC3_GCTL_SCALEDOWN(3)
> >  #define DWC3_GCTL_DISSCRAMBLE		(1 << 3)
> > +#define DWC3_GCTL_U2EXIT_LFPS		(1 << 2)
> >  #define DWC3_GCTL_GBLHIBERNATIONEN	(1 << 1)
> >  #define DWC3_GCTL_DSBLCLKGTNG		(1 << 0)
> >  
> > diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c
> > index bbe946c..cdb9b04 100644
> > --- a/drivers/usb/dwc3/dwc3-pci.c
> > +++ b/drivers/usb/dwc3/dwc3-pci.c
> > @@ -149,7 +149,8 @@ static int dwc3_pci_probe(struct pci_dev *pci,
> >  	if (pci->vendor == PCI_VENDOR_ID_AMD && pci->device ==
> >  			PCI_DEVICE_ID_AMD_NL) {
> >  		dwc3_pdata.has_lpm_erratum = true;
> > -		dwc3_pdata.quirks |= DWC3_QUIRK_AMD_NL;
> > +		dwc3_pdata.quirks |= DWC3_QUIRK_AMD_NL
> > +			| DWC3_QUIRK_U2EXIT_LFPS;
> >  	}
> 
> should be combined and the last patch in the series.
> 

You want to make all the AMD quirks enablement info and device id at
last patch, right?

Thanks,
Rui
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/