linux-kernel - [PATCH] scsi: storvsc: Force SPC-3 for Win8 Hosts or Later

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1413869523-38783-1-git-send-email-jleung@v10networks.ca>
Date:	Tue, 21 Oct 2014 05:32:03 +0000
From:	Jeff Leung <jleung@...networks.ca>
To:	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
	devel@...uxdriverproject.org
Cc:	kys@...rosoft.com, James.Bottomley@...senPartnership.com,
	Jeff Leung <jleung@...networks.ca>
Subject: [PATCH] scsi: storvsc: Force SPC-3 for Win8 Hosts or Later

This patch forces SPC-3 for Hyper-V disks on the VMBus. As Windows 10's
virtual SAS bus is SPC-3 compliant and there are no negative side effects
on forcing SPC-3 compliance for Win8 hosts, this patch enables SPC-3
compliance by forcing it on for hosts with versions later than Win8.

Forcing SPC-3 compliance for hosts earlier than Win10 also enables
TRIM support.

Suggested by: James Bottomley <James.Bottomley@...senPartnership.com>
Signed-off-by: Jeff Leung <jleung@...networks.ca>
---
 drivers/scsi/storvsc_drv.c |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
index ed0f899..afcc68e 100644
--- a/drivers/scsi/storvsc_drv.c
+++ b/drivers/scsi/storvsc_drv.c
@@ -1449,6 +1449,15 @@ static int storvsc_device_configure(struct scsi_device *sdevice)
 
 	sdevice->no_write_same = 1;
 
+	/*
+	 * If the host is Win2k12 or later, we pretend to be SPC-3 compliant
+	 * and send RC16 which activates TRIM. We will only enable this on a
+	 * host with levels greater than VERSION_WIN8
+	 */
+	if (vmbus_proto_version >= VERSION_WIN8) {
+		sdevice->scsi_level = SCSI_SPC_3;
+	}
+
 	return 0;
 }
 
-- 
1.7.2.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/