linux-kernel - Re: [PATCH 1/2] mtd: atmel_nand: use __iowrite32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54462F6C.1030307@atmel.com>
Date:	Tue, 21 Oct 2014 18:03:24 +0800
From:	Josh Wu <josh.wu@...el.com>
To:	Vinod Koul <vinod.koul@...el.com>, <linux-mtd@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>
CC:	David Woodhouse <dwmw2@...radead.org>,
	Brian Norris <computersforpeace@...il.com>,
	Jingoo Han <jg1.han@...sung.com>,
	"Ezequiel Garcia" <ezequiel.garcia@...e-electrons.com>,
	Mark Brown <broonie@...aro.org>,
	Nicolas Ferre <nicolas.ferre@...el.com>,
	"Bartlomiej Zolnierkiewicz" <b.zolnierkie@...sung.com>,
	Herve Codina <Herve.CODINA@...ad.com>,
	Bo Shen <voice.shen@...el.com>,
	Fabio Estevam <fabio.estevam@...escale.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Michael Grzeschik <m.grzeschik@...gutronix.de>,
	Josh Triplett <josh@...htriplett.org>,
	Wei Yongjun <yongjun_wei@...ndmicro.com.cn>,
	"Huang Shijie" <shijie8@...il.com>,
	Michael Opdenacker <michael.opdenacker@...e-electrons.com>
Subject: Re: [PATCH 1/2] mtd: atmel_nand: use __iowrite32_copy for 32 bit
 copy

Hi, Vinod

On 10/21/2014 12:06 AM, Vinod Koul wrote:
> The driver was also using own method to do 32bit copy, turns out
> we have a kernel API so use that instead
>
> Signed-off-by: Vinod Koul <vinod.koul@...el.com>

Thanks for the patch.
Acked-by: Josh Wu <josh.wu@...el.com>

BTW, is there any similar kernel API that is for the read from io?

Best Regards,
Josh Wu

> ---
>   drivers/mtd/nand/atmel_nand.c |   10 +++-------
>   1 files changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
> index e321c56..b03e80d 100644
> --- a/drivers/mtd/nand/atmel_nand.c
> +++ b/drivers/mtd/nand/atmel_nand.c
> @@ -265,14 +265,10 @@ static void memcpy32_fromio(void *trg, const void __iomem  *src, size_t size)
>   		*t++ = readl_relaxed(s++);
>   }
>   
> -static void memcpy32_toio(void __iomem *trg, const void *src, int size)
> +static inline void memcpy32_toio(void __iomem *trg, const void *src, int size)
>   {
> -	int i;
> -	u32 __iomem *t = trg;
> -	const u32 *s = src;
> -
> -	for (i = 0; i < (size >> 2); i++)
> -		writel_relaxed(*s++, t++);
> +	/* __iowrite32_copy use 32bit size values so divide by 4 */
> +	__iowrite32_copy(trg, src, size/4);
>   }
>   
>   /*

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/