lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 21 Oct 2014 13:13:57 +0100 From: One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk> To: Matej Mužila <mmuzila@...hat.com> Cc: kys@...rosoft.com, devel@...uxdriverproject.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/3] tools: hv: fcopy_daemon: Check buffer limits On Tue, 21 Oct 2014 13:49:00 +0200 Matej Mužila <mmuzila@...hat.com> wrote: > From: Matej Mužila <mmuzila@...hat.com> > > Check if cpmsg->size is in limits of DATA_FRAGMENT > > Signed-off-by: Matej Mužila <mmuzila@...hat.com> > Acked-by: K. Y. Srinivasan <kys@...rosoft.com> > --- > If corrupted data are read from /dev/vmbus/hv_fcopy, pwrite can > read from memory outside of the buffer (defined at line 138). > Added check. > --- > @@ -104,6 +104,10 @@ static int hv_copy_data(struct hv_do_fcopy *cpmsg) > { > ssize_t bytes_written; > > + // Check if the cpmsg->size is in limits of DATA_FRAGMENT > + if (cpmsg->size > DATA_FRAGMENT * sizeof(__u8)) > + return HV_E_FAIL; > + - C style comments for coding style, also sizeof(__u8) is by definition 1 so it's perhaps surplus ? Also your patch block is devoid of a few thins like the file name... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists