lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 21 Oct 2014 13:30:01 +0100 From: Lee Jones <lee.jones@...aro.org> To: Gyungoh Yoo <gyungoh@...il.com> Cc: sameo@...ux.intel.com, jg1.han@...sung.com, cooloney@...il.com, broonie@...nel.org, lgirdwood@...il.com, jack.yoo@...worksinc.com, linux-kernel@...r.kernel.org, devicetree@...r.kernel.org, grant.likely@...aro.org, robh+dt@...nel.org, mark.rutland@....com, ijc+devicetree@...lion.org.uk, galak@...eaurora.org, pawel.moll@....com, heiko@...ech.de, jason@...edaemon.net, shawn.guo@...escale.com, treding@...dia.com, florian.vaussard@...l.ch, trivial@...nel.org, linux@...ck-us.net, andrew@...n.ch, jic23@...nel.org Subject: Re: [RESUBMIT PATCH v4 1/8] mfd: Add support for Skyworks SKY81452 driver On Mon, 13 Oct 2014, Gyungoh Yoo wrote: > Signed-off-by: Gyungoh Yoo <jack.yoo@...worksinc.com> > --- > Changes v4: > Removed MODULE_VERSION() > Modified license to GPLv2 > > Changes v3: > Fixed the backlight name from 'sky81452-bl' to 'sky81452-backlight' > Assigned mfd_cell.of_compatible for binding device node > Modified error messages > > Changes v2: > Renamed CONFIG_SKY81452 to CONFIG_MFD_SKY81452 > Changed the dependency from I2C=y to I2C, for CONFIG_MFD_SKY81452 > Added message for exception or errors > > drivers/mfd/Kconfig | 12 +++++ > drivers/mfd/Makefile | 1 + > drivers/mfd/sky81452.c | 110 +++++++++++++++++++++++++++++++++++++++++++ > include/linux/mfd/sky81452.h | 32 +++++++++++++ > 4 files changed, 155 insertions(+) > create mode 100644 drivers/mfd/sky81452.c > create mode 100644 include/linux/mfd/sky81452.h [...] > +++ b/include/linux/mfd/sky81452.h > @@ -0,0 +1,32 @@ > +/* > + * sky81452.h SKY81452 MFD driver > + * > + * Copyright 2014 Skyworks Solutions Inc. > + * Author : Gyungoh Yoo <jack.yoo@...worksinc.com> > + * > + * This program is free software; you can redistribute it and/or modify it > + * under the terms of the GNU General Public License as published by the > + * Free Software Foundation; either version 2, or (at your option) any > + * later version. > + * > + * This program is distributed in the hope that it will be useful, but > + * WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License along > + * with this program; if not, see <http://www.gnu.org/licenses/>. > + */ > + > +#ifndef _SKY81452_H > +#define _SKY81452_H > + > +#include <linux/sky81452-backlight.h> Shouldn't this live in linux/platform_data? > +#include <linux/regulator/machine.h> > + > +struct sky81452_platform_data { > + struct sky81452_bl_platform_data *bl_pdata; > + struct regulator_init_data *regulator_init_data; > +}; > + > +#endif -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists