linux-kernel - Re: [PATCH] power: reset: at91-reset: fix power down register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 21 Oct 2014 16:18:34 +0200
From:	Nicolas Ferre <nicolas.ferre@...el.com>
To:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
	"Dmitry Eremin-Solenikov" <dbaryshkov@...il.com>,
	David Woodhouse <dwmw2@...radead.org>
CC:	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	Boris Brezillon <boris.brezillon@...e-electrons.com>,
	<linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] power: reset: at91-reset: fix power down register

On 20/10/2014 20:27, Alexandre Belloni :
> In the case of at91sam9g45_restart(), the driver is writing
> AT91_DDRSDRC_LPCB_POWER_DOWN to AT91_DDRSDRC_RTR, this should actually be
> AT91_DDRSDRC_LPR.
> 
> Signed-off-by: Alexandre Belloni <alexandre.belloni@...e-electrons.com>

Absolutely:
Acked-by: Nicolas Ferre <nicolas.ferre@...el.com>

If you don't mind Dmitry, I'll take this patch through the at91/arm-soc
git trees in my next at91-3.18-fixes branch.

Thanks Alex, bye,

> ---
>  drivers/power/reset/at91-reset.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/power/reset/at91-reset.c b/drivers/power/reset/at91-reset.c
> index 3611806c9cfd..3cb36693343a 100644
> --- a/drivers/power/reset/at91-reset.c
> +++ b/drivers/power/reset/at91-reset.c
> @@ -100,11 +100,11 @@ static void at91sam9g45_restart(enum reboot_mode mode, const char *cmd)
>  		/* Disable SDRAM0 accesses */
>  		"1:	str	%3, [%0, #" __stringify(AT91_DDRSDRC_RTR) "]\n\t"
>  		/* Power down SDRAM0 */
> -		"	str	%4, [%0, #" __stringify(AT91_DDRSDRC_RTR) "]\n\t"
> +		"	str	%4, [%0, #" __stringify(AT91_DDRSDRC_LPR) "]\n\t"
>  		/* Disable SDRAM1 accesses */
>  		"	strne	%3, [%1, #" __stringify(AT91_DDRSDRC_RTR) "]\n\t"
>  		/* Power down SDRAM1 */
> -		"	strne	%4, [%1, #" __stringify(AT91_DDRSDRC_RTR) "]\n\t"
> +		"	strne	%4, [%1, #" __stringify(AT91_DDRSDRC_LPR) "]\n\t"
>  		/* Reset CPU */
>  		"	str	%5, [%2, #" __stringify(AT91_RSTC_CR) "]\n\t"
>  
> 


-- 
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/