linux-kernel - Re: [PATCH] checkpatch: Improve warning message for "needless if" case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1413909608.12828.5.camel@perches.com>
Date:	Tue, 21 Oct 2014 09:40:08 -0700
From:	Joe Perches <joe@...ches.com>
To:	Fabio Estevam <fabio.estevam@...escale.com>
Cc:	festevam@...il.com, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] checkpatch: Improve warning message for "needless if"
 case

On Tue, 2014-10-21 at 12:33 -0200, Fabio Estevam wrote:
> Break the sentence so that it looks better:
> 
> WARNING: debugfs_remove(NULL) is safe. This check is probably not required
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -4446,7 +4446,7 @@ sub process {
>  			my $expr = '\s*\(\s*' . quotemeta($1) . '\s*\)\s*;';
>  			if ($line =~ /\b(kfree|usb_free_urb|debugfs_remove(?:_recursive)?)$expr/) {
>  				WARN('NEEDLESS_IF',
> -				     "$1(NULL) is safe this check is probably not required\n" . $hereprev);
> +				     "$1(NULL) is safe. This check is probably not required\n" . $hereprev);
>  			}
>  		}
>  

Mixing sentences with and without periods is jarring.
I'd prefer a comma or a dash.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/