linux-kernel - Re: [PATCH] checkpatch: Improve warning message for "needless if" case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1413910281.12828.6.camel@perches.com>
Date:	Tue, 21 Oct 2014 09:51:21 -0700
From:	Joe Perches <joe@...ches.com>
To:	Fabio Estevam <festevam@...il.com>
Cc:	Fabio Estevam <fabio.estevam@...escale.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] checkpatch: Improve warning message for "needless if"
 case

On Tue, 2014-10-21 at 14:44 -0200, Fabio Estevam wrote:
> On Tue, Oct 21, 2014 at 2:40 PM, Joe Perches <joe@...ches.com> wrote:
> 
> >
> > Mixing sentences with and without periods is jarring.
> > I'd prefer a comma or a dash.
> 
> Or what about?
> 
> "is safe and this check is probably not required"

That'd be fine too

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/