linux-kernel - Re: [PATCH v2 01/47] kernel: Add support for poweroff handler call chain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 21 Oct 2014 20:27:50 +0200
From:	Johan Hovold <johan@...nel.org>
To:	Guenter Roeck <linux@...ck-us.net>
Cc:	Johan Hovold <johan@...nel.org>, linux-kernel@...r.kernel.org,
	linux-pm@...r.kernel.org, Alan Cox <gnomes@...rguk.ukuu.org.uk>,
	Alexander Graf <agraf@...e.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Heiko Stuebner <heiko@...ech.de>,
	Lee Jones <lee.jones@...aro.org>,
	Len Brown <len.brown@...el.com>, Pavel Machek <pavel@....cz>,
	Philippe Rétornaz 
	<philippe.retornaz@...il.com>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Romain Perier <romain.perier@...il.com>
Subject: Re: [PATCH v2 01/47] kernel: Add support for poweroff handler call
 chain

On Tue, Oct 21, 2014 at 08:50:47AM -0700, Guenter Roeck wrote:
> On Tue, Oct 21, 2014 at 11:34:05AM +0200, Johan Hovold wrote:
> > On Mon, Oct 20, 2014 at 09:12:17PM -0700, Guenter Roeck wrote:
> > 
> > > v2:
> > > - poweroff -> power_off
> > 
> > Do you want to stick to power[-_ ]off consistently throughout?
> > 
> 
> The string "poweroff" is used 819 times in today's upstream kernel.
> "power_off" is used 1,496 times, presumably mostly in variable names.
> "power-off" is used 145 times.
> 
> So, yes, I can change all newly introduced variable and function names
> from poweroff to power_off, and all newly introduced descriptive text
> from poweroff to power-off if that makes you happy. It won't improve
> consistency, though, since many of the current poweroff functions
> are named "something_poweroff". Hope you don't expect me to change
> all those function names as well.

Consistency is always nice, even if it's just within the files and
infrastructure you're adding.

But as already mentioned, the most important thing is that the interface
is consistent (e.g. function and constant names).

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/