lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 21 Oct 2014 14:03:50 -0600 From: Bjorn Helgaas <bhelgaas@...gle.com> To: Jason Wessel <jason.wessel@...driver.com>, Ralf Baechle <ralf@...ux-mips.org>, Ingo Molnar <mingo@...hat.com>, John Stultz <john.stultz@...aro.org>, Eric Paris <eparis@...hat.com>, "H. Peter Anvin" <hpa@...or.com>, Thomas Gleixner <tglx@...utronix.de>, Andrew Morton <akpm@...ux-foundation.org> Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-mips@...ux-mips.org" <linux-mips@...ux-mips.org> Subject: Re: [PATCH v1 03/10] MIPS: CPC: Make mips_cpc_phys_base() static On Wed, Oct 15, 2014 at 5:28 PM, Bjorn Helgaas <bhelgaas@...gle.com> wrote: > [+cc linux-mips for real this time. sheesh] > > On Wed, Oct 15, 2014 at 5:27 PM, Bjorn Helgaas <bhelgaas@...gle.com> wrote: >> [+cc linux-mips@...ux-mips.org] >> >> On Wed, Oct 15, 2014 at 11:06 AM, Bjorn Helgaas <bhelgaas@...gle.com> wrote: >>> There's only one implementation of mips_cpc_phys_base(), and it's only used >>> within the same file, so it doesn't need to be weak, and it doesn't need an >>> extern declaration. >>> >>> Remove the extern mips_cpc_phys_base() declaration and make it static. >>> >>> Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com> >>> CC: linux-mips@...ux-mips.org I'm dropping this patch from my series because I haven't seen any response from the MIPS folks. >>> --- >>> arch/mips/include/asm/mips-cpc.h | 10 ---------- >>> arch/mips/kernel/mips-cpc.c | 2 +- >>> 2 files changed, 1 insertion(+), 11 deletions(-) >>> >>> diff --git a/arch/mips/include/asm/mips-cpc.h b/arch/mips/include/asm/mips-cpc.h >>> index e139a534e0fd..8ff92cd74bde 100644 >>> --- a/arch/mips/include/asm/mips-cpc.h >>> +++ b/arch/mips/include/asm/mips-cpc.h >>> @@ -28,16 +28,6 @@ extern void __iomem *mips_cpc_base; >>> extern phys_t mips_cpc_default_phys_base(void); >>> >>> /** >>> - * mips_cpc_phys_base - retrieve the physical base address of the CPC >>> - * >>> - * This function returns the physical base address of the Cluster Power >>> - * Controller memory mapped registers, or 0 if no Cluster Power Controller >>> - * is present. It may be overriden by individual platforms which determine >>> - * this address in a different way. >>> - */ >>> -extern phys_t __weak mips_cpc_phys_base(void); >>> - >>> -/** >>> * mips_cpc_probe - probe for a Cluster Power Controller >>> * >>> * Attempt to detect the presence of a Cluster Power Controller. Returns 0 if >>> diff --git a/arch/mips/kernel/mips-cpc.c b/arch/mips/kernel/mips-cpc.c >>> index ba473608a347..36c20ae509d8 100644 >>> --- a/arch/mips/kernel/mips-cpc.c >>> +++ b/arch/mips/kernel/mips-cpc.c >>> @@ -21,7 +21,7 @@ static DEFINE_PER_CPU_ALIGNED(spinlock_t, cpc_core_lock); >>> >>> static DEFINE_PER_CPU_ALIGNED(unsigned long, cpc_core_lock_flags); >>> >>> -phys_t __weak mips_cpc_phys_base(void) >>> +static phys_t mips_cpc_phys_base(void) >>> { >>> u32 cpc_base; >>> >>> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists