linux-kernel - Re: [PATCH] ARM: dts: DRA7: Add aliases for all serial ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5446BCEB.3020708@ti.com>
Date:	Tue, 21 Oct 2014 15:07:07 -0500
From:	Nishanth Menon <nm@...com>
To:	Arnd Bergmann <arnd@...db.de>,
	<linux-arm-kernel@...ts.infradead.org>
CC:	Tony Lindgren <tony@...mide.com>, <devicetree@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <linux-omap@...r.kernel.org>,
	"Franklin Cooper Jr." <fcooper@...com>
Subject: Re: [PATCH] ARM: dts: DRA7: Add aliases for all serial ports

On 10/21/2014 02:57 PM, Arnd Bergmann wrote:
> On Tuesday 21 October 2014 11:18:15 Nishanth Menon wrote:
>> Add serial port aliases for consoles > 6.
>>
>> Signed-off-by: Nishanth Menon <nm@...com>
>> ---
>>  arch/arm/boot/dts/dra7.dtsi |    4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
>> index 9cc9843..208dd83 100644
>> --- a/arch/arm/boot/dts/dra7.dtsi
>> +++ b/arch/arm/boot/dts/dra7.dtsi
>> @@ -34,6 +34,10 @@
>>                 serial3 = &uart4;
>>                 serial4 = &uart5;
>>                 serial5 = &uart6;
>> +               serial6 = &uart7;
>> +               serial7 = &uart8;
>> +               serial8 = &uart9;
>> +               serial9 = &uart10;
>>
> 
> I think this was wrong to start with: The aliases should be in the per-board
> .dts file and only list the ones that are actually connected to the outside.
> 
> Otherwise the numbering won't match what's written on the board.

At least in the case of DRA7 boards, they are not written specifically
since they come out over onboard FTDI usb2serial.

This will at least ensure that /dev/ttyO9 will always point to uart10
no matter the board, instead of having ttyO0 always pointing to
console serial port no matter the board (and having to guess which
figure out it actually was aliased to).

-- 
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/