| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1413924669-26732-1-git-send-email-sasha.levin@oracle.com> Date: Tue, 21 Oct 2014 16:51:09 -0400 From: Sasha Levin <sasha.levin@...cle.com> To: davem@...emloft.net Cc: a.ryabinin@...sung.com, pablo@...filter.org, mschmidt@...hat.com, akpm@...ux-foundation.org, linux-kernel@...r.kernel.org, netdev@...r.kernel.org, Sasha Levin <sasha.levin@...cle.com> Subject: [PATCH] netlink: don't copy over empty attribute data netlink uses empty data to seperate different levels. However, we still try to copy that data from a NULL ptr using memcpy, which is an undefined behaviour. Signed-off-by: Sasha Levin <sasha.levin@...cle.com> --- lib/nlattr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/nlattr.c b/lib/nlattr.c index 9c3e85f..6512b43 100644 --- a/lib/nlattr.c +++ b/lib/nlattr.c @@ -430,7 +430,8 @@ void __nla_put(struct sk_buff *skb, int attrtype, int attrlen, struct nlattr *nla; nla = __nla_reserve(skb, attrtype, attrlen); - memcpy(nla_data(nla), data, attrlen); + if (data) + memcpy(nla_data(nla), data, attrlen); } EXPORT_SYMBOL(__nla_put); -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists