| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20141021233518.GA15840@cloud> Date: Tue, 21 Oct 2014 16:35:18 -0700 From: josh@...htriplett.org To: Peter Hüwe <PeterHuewe@....de> Cc: linux-kernel@...r.kernel.org Subject: Re: .exit.text section in vmlinux ? On Tue, Oct 21, 2014 at 11:19:01PM +0200, Peter Hüwe wrote: > as far as I remember everything marked with __exit or __exit_data will only be > used/called when unloading a module, and gets moved to the .exit.text or > .exit.data sections. > > Why are these sections present in the vmlinux/vmlinux.bin/bzImage and not > dropped by the linker or at least objdump? > This code will never be called for everything compiled in - in an allyesconfig > build these sections account for ~80kb of code. > > Is there something I'm missing here, or can we add "--remove-section > .exit.data --remove-section .exit.text" to the OBJCOPYFLAGS for vmlinux? Good catch! I didn't realize that section even appeared in vmlinux; it should be entirely omitted. Removing it via objcopy would work, but seems suboptimal, since that won't let the compiler know the functions are unused (and thus that it can throw away code and data only referenced from __exit, or inline functions into their now-only caller, etc). So, ideally, when compiling code in the kernel rather than in modules, we should tell the compiler enough to omit functions tagged as __exit. (Also, in the course of working on this, I discovered that several files declare functions as "static inline ... __exit", which makes no sense, and which actually forces an out-of-line version to exist even if the function has no body. For instance, exit_amd_microcode and bcma_host_soc_unregister_driver.) The following patch seems to mostly do the right thing, though for some reason some __exit functions remain in the final binary (such as md_exit and mon_exit): --->8--- >From 1646d051a4a4c18b9a6163fceabcafa20628c728 Mon Sep 17 00:00:00 2001 From: Josh Triplett <josh@...htriplett.org> Date: Tue, 21 Oct 2014 16:14:19 -0700 Subject: [PATCH] linux/init.h: Always omit __exit code and data for in-kernel compilation __exit code and data only exists for module removal; when compiling such code in the kernel, omit the __exit functions to save space. For x86 defconfig this saves about 9k, and significantly more in the compiled binary size. Signed-off-by: Josh Triplett <josh@...htriplett.org> --- include/linux/init.h | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/include/linux/init.h b/include/linux/init.h index 2df8e8d..daa329d 100644 --- a/include/linux/init.h +++ b/include/linux/init.h @@ -42,8 +42,14 @@ #define __init __section(.init.text) __cold notrace #define __initdata __section(.init.data) #define __initconst __constsection(.init.rodata) + +#ifdef MODULE #define __exitdata __section(.exit.data) #define __exit_call __used __section(.exitcall.exit) +#else +#define __exitdata __always_unused +#define __exit_call __always_unused +#endif /* * Some architecture have tool chains which do not handle rodata attributes @@ -89,7 +95,11 @@ #define __exitused __used #endif -#define __exit __section(.exit.text) __exitused __cold notrace +#ifdef MODULE +#define __exit __section(.exit.text) __cold notrace +#else +#define __exit __always_unused +#endif /* temporary, until all users are removed */ #define __cpuinit -- 2.1.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists