linux-kernel - Re: [PATCH] fbcon: Fix option parsing control flow in fb_console

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5447546A.8070800@ti.com>
Date:	Wed, 22 Oct 2014 09:53:30 +0300
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	Maarten ter Huurne <maarten@...ewalker.org>
CC:	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	<linux-fbdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	Paul Cercueil <paul@...pouillou.net>
Subject: Re: [PATCH] fbcon: Fix option parsing control flow in fb_console_setup

On 09/10/14 12:48, Maarten ter Huurne wrote:
> Since strsep is used to tokenize the options string, after each option
> match the code should use "continue" to get the next token from strsep.
> This patch applies this pattern consistently.
> 
> Previously, for "scrollback:" and "map:" the parse code would return
> (unconditionally: strsep ensures *options != ','), causing any
> following option to be ignored, while for "vc:" the parse code would
> go on to parse further options within the same token, which could lead
> to invalid input being accepted.
> 
> Signed-off-by: Maarten ter Huurne <maarten@...ewalker.org>
> Acked-by: Paul Cercueil <paul@...pouillou.net>
> ---
>  drivers/video/console/fbcon.c | 19 +++++++++----------
>  1 file changed, 9 insertions(+), 10 deletions(-)

Thanks, queued for 3.18 fixes.

 Tomi



Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)