lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 22 Oct 2014 10:03:36 +0200 From: Sebastian Andrzej Siewior <bigeasy@...utronix.de> To: Nishanth Menon <nm@...com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Tony Lindgren <tony@...mide.com> CC: linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org, Jiri Slaby <jslaby@...e.cz>, linux-omap@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, "Franklin Cooper Jr." <fcooper@...com> Subject: Re: [PATCH] tty: serial: omap: increase max consoles to 10 On 10/21/2014 06:23 PM, Nishanth Menon wrote: > > The final solution is to transition off to use 8250 driver and no > dependency on console structures and move away from omap-serial driver, > hence no major cleanups are done for this driver. So the shiny new driver works for you, is this what you are saying? > diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c > index 18c30ca..4f9cbb6 100644 > --- a/drivers/tty/serial/omap-serial.c > +++ b/drivers/tty/serial/omap-serial.c > @@ -46,7 +46,7 @@ > > #include <dt-bindings/gpio/gpio.h> > > -#define OMAP_MAX_HSUART_PORTS 6 > +#define OMAP_MAX_HSUART_PORTS 10 > > #define UART_BUILD_REVISION(x, y) (((x) << 8) | (y)) Please also add a check in the probe code that "up->port.line" does not exceed OMAP_MAX_HSUART_PORTS again. So we leave the probe function with an error code instead. Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists