linux-kernel - Re: [RESEND PATCH 1/3 v5] sched: Remove update_rq_runnable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141022002311.GD2577@intel.com>
Date:	Wed, 22 Oct 2014 08:23:11 +0800
From:	Yuyang Du <yuyang.du@...el.com>
To:	mingo@...hat.com, peterz@...radead.org,
	linux-kernel@...r.kernel.org
Cc:	cebbert.lkml@...il.com, pjt@...gle.com, bsegall@...gle.com,
	arjan.van.de.ven@...el.com, len.brown@...el.com,
	rafael.j.wysocki@...el.com, alan.cox@...el.com,
	mark.gross@...el.com, fengguang.wu@...el.com
Subject: Re: [RESEND PATCH 1/3 v5] sched: Remove update_rq_runnable_avg

On Fri, Oct 10, 2014 at 10:21:55AM +0800, Yuyang Du wrote:
>  
> diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c index 627b3c3..da0b7d5 100644
> --- a/kernel/sched/debug.c
> +++ b/kernel/sched/debug.c

> -	if (!se) {
> -		struct sched_avg *avg = &cpu_rq(cpu)->avg;
> -		P(avg->runnable_avg_sum);
> -		P(avg->runnable_avg_period);
> -		return;
> -	}

This is a bug. Should be:

-	if (!se)
-		return;

Thanks to 0Day, and good improvement as previously this bug was not found.
Also thanks to Chuck Ebbert.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/