| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1413981831-6902-1-git-send-email-jack@suse.cz> Date: Wed, 22 Oct 2014 14:43:51 +0200 From: Jan Kara <jack@...e.cz> To: Andrew Morton <akpm@...ux-foundation.org> Cc: linux-kernel@...r.kernel.org, Jan Kara <jack@...e.cz>, Rasmus Villemoes <linux@...musvillemoes.dk>, stable@...r.kernel.org Subject: [PATCH] bitmap: Fix undefined shift in __bitmap_shift_left() It __bitmap_shift_left() is asked to shift by a multiple of BITS_PER_LONG, it will try to shift a long value by BITS_PER_LONG bits which is undefined. Change the function to take this into account. Coverity-id: 1192175 CC: Rasmus Villemoes <linux@...musvillemoes.dk> CC: stable@...r.kernel.org Signed-off-by: Jan Kara <jack@...e.cz> --- lib/bitmap.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/bitmap.c b/lib/bitmap.c index cd250a2e14cb..02a8a439fcc7 100644 --- a/lib/bitmap.c +++ b/lib/bitmap.c @@ -172,7 +172,9 @@ void __bitmap_shift_left(unsigned long *dst, upper = src[k]; if (left && k == lim - 1) upper &= (1UL << left) - 1; - dst[k + off] = lower >> (BITS_PER_LONG - rem) | upper << rem; + dst[k + off] = upper << rem; + if (rem) + dst[k + off] |= lower >> (BITS_PER_LONG - rem); if (left && k + off == lim - 1) dst[k + off] &= (1UL << left) - 1; } -- 1.8.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists