linux-kernel - Re: regression: checkpatch.pl fails when called via symlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ppdktewn.fsf@intel.com>
Date:	Wed, 22 Oct 2014 16:25:28 +0300
From:	Jani Nikula <jani.nikula@...el.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Andy Whitcroft <apw@...onical.com>,
	Kees Cook <keescook@...omium.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: regression: checkpatch.pl fails when called via symlink

On Wed, 22 Oct 2014, Joe Perches <joe@...ches.com> wrote:
> On Wed, 2014-10-22 at 13:43 +0300, Jani Nikula wrote:
>> Since commit 66b47b4a9dad00e45c049d79966de9a3a1f4d337
>> Author: Kees Cook <keescook@...omium.org>
>> Date:   Mon Oct 13 15:51:57 2014 -0700
>> 
>>     checkpatch: look for common misspellings
>> 
>> checkpatch.pl dies with
>> 
>> checkpatch.pl: Can't open /path/to/spelling.txt for reading: No such file or directory
>> 
>> if it's called through a symlink in /path/to/checkpatch.pl pointing at
>> the actual script.
>> 
>> Please fail graciously, and just ignore spelling if you can't find
>> spelling.txt. Or better yet, follow the links if you can.
>
> I agree it should fail better, but I'm also curious.
> Why you want to use a symlink?

Simply because I think having $HOME/bin in $PATH and a symlink there is
better than the alternatives.

I don't want to add scripts to $PATH because there's so much cruft. I
don't want to copy checkpatch.pl (and now spelling.txt) because I
generally want it to stay up-to-date. I don't want to use an alias
because some maintainer scripts would break. I don't want to use a full
path because it's tedious, and potentially different on different
machines.

Reference: http://xkcd.com/1172/


BR,
Jani.

-- 
Jani Nikula, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/