linux-kernel - Re: [PATCH v4 8/8] ARM: mediatek: Add config option for mediatek SoCs.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 22 Oct 2014 15:53:23 +0200
From:	Matthias Brugger <matthias.bgg@...il.com>
To:	Yingjoe Chen <yingjoe.chen@...iatek.com>
Cc:	Rob Herring <robh+dt@...nel.org>, arm@...nel.org,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Russell King <linux@....linux.org.uk>,
	Olof Johansson <olof@...om.net>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	srv_heupstream <srv_heupstream@...iatek.com>,
	Yingjoe Chen <yingjoe.chen@...il.com>,
	Hsien-Chun Yen <hc.yen@...iatek.com>,
	huang eddie <eddie.huang@...iatek.com>,
	Nathan Chung <nathan.chung@...iatek.com>,
	Yuhau Chen <yh.chen@...iatek.com>,
	Sascha Hauer <kernel@...gutronix.de>
Subject: Re: [PATCH v4 8/8] ARM: mediatek: Add config option for mediatek SoCs.

Hi Joe,

2014-10-22 15:31 GMT+02:00 Yingjoe Chen <yingjoe.chen@...iatek.com>:
>
> Hi Matthias,
>
> On Wed, 2014-10-22 at 15:18 +0200, Matthias Brugger wrote:
>> 2014-10-22 12:29 GMT+02:00 Joe.C <yingjoe.chen@...iatek.com>:
>> > +
>> > +if ARCH_MEDIATEK
>> > +
>> > +config MACH_MT6589
>> > +       bool "MediaTek MT6589 SoCs support"
>> > +       default ARCH_MEDIATEK
>> > +
>> > +config MACH_MT8127
>> > +       bool "MediaTek MT8127 SoCs support"
>> > +       default ARCH_MEDIATEK
>> > +
>> > +config MACH_MT8135
>> > +       bool "MediaTek MT8135 SoCs support"
>> > +       default ARCH_MEDIATEK
>> > +
>> > +endif
>>
>> MACH_MTxxxx are not used nowhere, please remove them.
>
> Yes, they are not used in this series yet.
>
> MACH_MT8135 was used in mt8135 pinctrl driver [1] and will be used in
> mt8135 clk driver we are about to send. I don't want to create false
> dependency between these 2 series so I put it here.
> Do you prefer add them when they are first used?

Yes please add them, when they are first used.
Today I had a look on the pinctrl patches you mentioned. It looks to
me as if the config is not needed in the series.

Thanks,
Matthias

[0] http://thread.gmane.org/gmane.linux.ports.arm.kernel/358505

>
> Joe.C
>
> [1]
> http://lists.infradead.org/pipermail/linux-arm-kernel/2014-September/289288.html
>
>



-- 
motzblog.wordpress.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/