linux-kernel - Re: [PATCH] null_blk: Cleanup error recovery in null_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5447B84B.3040707@kernel.dk>
Date:	Wed, 22 Oct 2014 07:59:39 -0600
From:	Jens Axboe <axboe@...nel.dk>
To:	Jan Kara <jack@...e.cz>
CC:	hch@....de, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] null_blk: Cleanup error recovery in null_add_dev()

On 10/22/2014 07:34 AM, Jan Kara wrote:
> When creation of queues fails in init_driver_queues(), we free the
> queues. But null_add_dev() doesn't test for this failure and continues
> with the setup leading to strange consequences, likely oops. Fix the
> problem by testing whether init_driver_queues() failed and do proper
> error cleanup.

Thanks Jan, applied.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/