linux-kernel - Re: [PATCH v2] xen/smp: Use die_complete completion when taking CPU down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5447CF27.2040506@zytor.com>
Date:	Wed, 22 Oct 2014 08:37:11 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Boris Ostrovsky <boris.ostrovsky@...cle.com>, tglx@...utronix.de,
	mingo@...hat.com, konrad.wilk@...cle.com, david.vrabel@...rix.com
CC:	tianyu.lan@...el.com, linux-kernel@...r.kernel.org,
	xen-devel@...ts.xenproject.org
Subject: Re: [PATCH v2] xen/smp: Use die_complete completion when taking CPU
 down

On 10/16/2014 09:47 AM, Boris Ostrovsky wrote:
> diff --git a/arch/x86/include/asm/smp.h b/arch/x86/include/asm/smp.h
> index 8cd27e0..a78c509 100644
> --- a/arch/x86/include/asm/smp.h
> +++ b/arch/x86/include/asm/smp.h
> @@ -149,7 +149,11 @@ static inline void arch_send_call_function_ipi_mask(const struct cpumask *mask)
>  	smp_ops.send_call_func_ipi(mask);
>  }
>  
> +#ifdef CONFIG_HOTPLUG_CPU
>  void cpu_disable_common(void);
> +void cpu_die_common(unsigned int cpu);
> +void play_dead_common(void);
> +#endif

We generally don't #ifdef prototypes unless they are inlines or macros
in the unconfiged case.

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/