linux-kernel - Re: [PATCH v4 00/12] fs/seq_file: introduce seq_hex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1413992885.2396.40.camel@linux.intel.com>
Date:	Wed, 22 Oct 2014 18:48:05 +0300
From:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:	Tadeusz Struk <tadeusz.struk@...el.com>
Cc:	Herbert Xu <herbert@...dor.apana.org.au>,
	Mauro Carvalho Chehab <m.chehab@...sung.com>,
	Helge Deller <deller@....de>,
	Ingo Tuchscherer <ingo.tuchscherer@...ibm.com>,
	Alexander Viro <viro@...iv.linux.org.uk>,
	linux-kernel@...r.kernel.org, Joe Perches <joe@...ches.com>,
	Marek Vasut <marex@...x.de>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Vladimir Kondratiev <qca_vkondrat@....qualcomm.com>,
	Benjamin Romer <benjamin.romer@...sys.com>,
	Catalin Marinas <catalin.marinas@....com>,
	Randy Dunlap <rdunlap@...radead.org>
Subject: Re: [PATCH v4 00/12] fs/seq_file: introduce seq_hex_dump() helper

On Thu, 2014-09-04 at 17:26 +0300, Andy Shevchenko wrote:
> This introduces a new helper and switches current users to use it. All are
> compiled tested, hexdump and kmemleak are tested by their test suits.
> 

Gently ping on this series.
Any comments?

> Changelog v4:
> - hexdump is amended to return value from which we can check an overflow
>  (patches 1/12 - 4/12)
> - seq_hex_dump pushes bytes directly to buffer and returns an error in case of
>   overflow (addresses Al Viro's comment)
> - append Acked-by for patches 8/12 and 9/12
> - convert more users (patches 10/12 - 12/12)
> 
> Changelog v3:
> - append Mauro's Ack
> - rebase on top of recent linux-next
> 
> Changelog v2:
> - append Acked-by and Reviewed-by tags
> - update commit messages in patches 3/5. and 5/5
> - update line size to be 32 bytes instead of 16 in patch 3/5
> - Joe found that output is changed in patch 4/5, thus I update commit message
>   there
> 
> Andy Shevchenko (12):
>   hexdump: introduce test suite
>   hexdump: fix ascii column for the tail of a dump
>   hexdump: do few calculations ahead
>   hexdump: makes it return amount of bytes placed in buffer
>   seq_file: provide an analogue of print_hex_dump()
>   saa7164: convert to seq_hex_dump()
>   crypto: qat - use seq_hex_dump() to dump buffers
>   parisc: use seq_hex_dump() to dump buffers
>   [S390] zcrypt: use seq_hex_dump() to dump buffers
>   staging: unisys: use seq_hex_dump() to dump buffers
>   kmemleak: use seq_hex_dump() to dump buffers
>   wil6210: use seq_hex_dump() to dump buffers
> 
>  .../crypto/qat/qat_common/adf_transport_debug.c    |  16 +-
>  drivers/media/pci/saa7164/saa7164-core.c           |  31 +---
>  drivers/net/wireless/ath/wil6210/debugfs.c         |  32 +---
>  drivers/parisc/ccio-dma.c                          |  14 +-
>  drivers/parisc/sba_iommu.c                         |  11 +-
>  drivers/s390/crypto/zcrypt_api.c                   |  10 +-
>  .../unisys/visorchannel/visorchannel_funcs.c       |  26 +--
>  fs/seq_file.c                                      |  50 ++++++
>  include/linux/printk.h                             |   6 +-
>  include/linux/seq_file.h                           |   4 +
>  lib/Kconfig.debug                                  |   3 +
>  lib/Makefile                                       |   4 +-
>  lib/hexdump.c                                      | 105 +++++++-----
>  lib/test-hexdump.c                                 | 180 +++++++++++++++++++++
>  mm/kmemleak.c                                      |  21 +--
>  15 files changed, 337 insertions(+), 176 deletions(-)
>  create mode 100644 lib/test-hexdump.c
> 


-- 
Andy Shevchenko <andriy.shevchenko@...el.com>
Intel Finland Oy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/