linux-kernel - Re: [PATCH v3 4/5] regulator: max77802: Parse regulator operating mode properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141022164813.GD2344@sirena.org.uk>
Date:	Wed, 22 Oct 2014 17:48:13 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Javier Martinez Canillas <javier.martinez@...labora.co.uk>
Cc:	Chanwoo Choi <cw00.choi@...sung.com>,
	Olof Johansson <olof@...om.net>,
	Chris Zhong <zyw@...k-chips.com>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Abhilash Kesavan <kesavan.abhilash@...il.com>,
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org
Subject: Re: [PATCH v3 4/5] regulator: max77802: Parse regulator operating
 mode properties

On Mon, Oct 20, 2014 at 04:47:51PM +0200, Javier Martinez Canillas wrote:

> +	char *states[PM_SUSPEND_MAX + 1] = {
> +		[PM_SUSPEND_MEM] = "regulator-state-mem",
> +		[PM_SUSPEND_MAX] = "regulator-state-disk",
> +	};

This still has the same problem as your previous patch with things not
being as joined up with the core as they should be.  What I'd like to
see is that the code to extract the number for each state is in the core
and then the drivers just provide a translation function to map from
this to the internal modes.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)