linux-kernel - RE: [alsa-devel] [PATCH] ASoC: atmel_ssc_dai: Track playback and capture CMR dividers separately.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 22 Oct 2014 04:47:21 +0000
From:	Peter Rosin <peda@...ntia.se>
To:	Bo Shen <voice.shen@...el.com>
CC:	"'alsa-devel@...a-project.org'" <alsa-devel@...a-project.org>,
	"Takashi Iwai" <tiwai@...e.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	"Mark Brown" <broonie@...nel.org>
Subject: RE: [alsa-devel] [PATCH] ASoC: atmel_ssc_dai: Track playback and
 capture CMR dividers separately.

Hi!

> Hi Peter,
> 
> On 10/21/2014 09:05 PM, Peter Rosin wrote:
> > I did some further tests, and the following program fails without the patch:
> 
> With the patch, it is OK?

Yes.

> > #include <sys/ioctl.h>
> > #include <unistd.h>
> > #include <fcntl.h>
> > #include <sys/soundcard.h>
> >
> > int
> > main(void)
> > {
> > 	int fd;
> > 	int format;
> > 	int channels;
> >
> > 	if ((fd = open("/dev/dsp", O_WRONLY, 0)) == -1) {
> > 		perror("open");
> > 		return 1;
> > 	}
> > 	format = AFMT_S16_LE;
> > 	if (ioctl(fd, SNDCTL_DSP_SETFMT, &format) == -1) {
> > 		perror("SNDCTL_DSP_SETFMT");
> > 		return 1;
> > 	}
> > 	channels = 2;
> > 	if (ioctl(fd, SNDCTL_DSP_CHANNELS, &channels) == -1) {
> > 		perror("SNDCTL_DSP_CHANNELS");
> > 		return 1;
> > 	}
> > 	return 0;
> > }
> >
> > Output:
> > SNDCTL_DSP_CHANNELS: Device or resource busy
> 
> This return from codec or from atmel_ssc_dai?

This -EBUSY definitely comes from atmel_ssc_set_dai_sysclk, when my
card-driver tries to set ATMEL_SSC_CMR_DIV. With the patch, it works.
(the codec is spdif-transmitter, since the i2c interface of the actual tfa9879
codec is not directly reachable from the linux cpu, but that has nothing to
do with this issue).

> > (I admin to having edited the above code slightly in this mail, so I
s/admin/admit/
> > might have introduced some silly bug, but you get what I mean, just
> > open the device and request some parameters, and boom: -EBUSY)

Cheers,
Peter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/