linux-kernel - Re: [PATCH 03/19] MIPS: sead3: Stop using GIC REG macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL1qeaE=QqHmyAecqdt=9chsLGHU82a-SkgFns0ae-y6Jy24iQ@mail.gmail.com>
Date:	Wed, 22 Oct 2014 11:01:15 -0700
From:	Andrew Bresticker <abrestic@...omium.org>
To:	Qais Yousef <qais.yousef@...tec.com>
Cc:	Ralf Baechle <ralf@...ux-mips.org>,
	Daniel Lezcano <daniel.lezcano@...aro.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Jason Cooper <jason@...edaemon.net>,
	Paul Burton <paul.burton@...tec.com>,
	John Crispin <blogic@...nwrt.org>,
	Linux-MIPS <linux-mips@...ux-mips.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 03/19] MIPS: sead3: Stop using GIC REG macros

On Wed, Oct 22, 2014 at 2:33 AM, Qais Yousef <qais.yousef@...tec.com> wrote:
> On 10/20/2014 08:03 PM, Andrew Bresticker wrote:
>>
>> Stop using the REG macros from gic.h and instead use proper iomem
>> accessors.
>>
>> Signed-off-by: Andrew Bresticker <abrestic@...omium.org>
>> ---
>>   arch/mips/mti-sead3/sead3-int.c | 7 +++----
>>   1 file changed, 3 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/mips/mti-sead3/sead3-int.c
>> b/arch/mips/mti-sead3/sead3-int.c
>> index 69ae185..995c401 100644
>> --- a/arch/mips/mti-sead3/sead3-int.c
>> +++ b/arch/mips/mti-sead3/sead3-int.c
>> @@ -20,16 +20,15 @@
>>   #define SEAD_CONFIG_BASE              0x1b100110
>>   #define SEAD_CONFIG_SIZE              4
>>   -static unsigned long sead3_config_reg;
>> +static void __iomem *sead3_config_reg;
>>     void __init arch_init_irq(void)
>>   {
>>         if (!cpu_has_veic)
>>                 mips_cpu_irq_init();
>>   -     sead3_config_reg = (unsigned
>> long)ioremap_nocache(SEAD_CONFIG_BASE,
>> -               SEAD_CONFIG_SIZE);
>> -       gic_present = (REG32(sead3_config_reg) &
>> SEAD_CONFIG_GIC_PRESENT_MSK) >>
>> +       sead3_config_reg = ioremap_nocache(SEAD_CONFIG_BASE,
>> SEAD_CONFIG_SIZE);
>> +       gic_present = (readl(sead3_config_reg) &
>> SEAD_CONFIG_GIC_PRESENT_MSK) >>
>>                 SEAD_CONFIG_GIC_PRESENT_SHF;
>>         pr_info("GIC: %spresent\n", (gic_present) ? "" : "not ");
>>         pr_info("EIC: %s\n",
>
>
> I think you need to use the __raw_readl() variant here and for all other
> similar changes.

Thanks, will do.

-Andrew
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/