linux-kernel - Re: [PATCH 2/5] perf, x86, uncore: Add Haswell-EP uncore support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAADnVQKWgm9smg5vtfFwt53RiNYidgV9kiq3C0B0Xekx0cUJJg@mail.gmail.com>
Date:	Wed, 22 Oct 2014 12:07:56 -0700
From:	Alexei Starovoitov <alexei.starovoitov@...il.com>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	Peter Zijlstra <peterz@...radead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...nel.org>, eranian@...gle.com,
	Thomas Gleixner <tglx@...utronix.de>,
	"Yan, Zheng" <zheng.z.yan@...el.com>,
	Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 2/5] perf, x86, uncore: Add Haswell-EP uncore support

On Thu, Sep 4, 2014 at 4:08 PM, Andi Kleen <andi@...stfloor.org> wrote:
> From: "Yan, Zheng" <zheng.z.yan@...el.com>
>
> The uncore subsystem in Haswell-EP is similar to Sandy/Ivy
> Bridge-EP. There are some differences in config register
> encoding and pci device IDs. The Haswell-EP uncore also
> supports a few new events. Add the Haswell-EP driver to
> the snbep split driver.
>
> v2: (AK): Add missing break. Add imc events. Add cbox nc/isoc/c6.
> Signed-off-by: Yan, Zheng <zheng.z.yan@...el.com>
> Signed-off-by: Andi Kleen <ak@...ux.intel.com>
> ---
>  arch/x86/kernel/cpu/perf_event_intel_uncore.c      |   7 +-
>  arch/x86/kernel/cpu/perf_event_intel_uncore.h      |   2 +
>  .../x86/kernel/cpu/perf_event_intel_uncore_snbep.c | 608 ++++++++++++++++++++-
>  3 files changed, 615 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kernel/cpu/perf_event_intel_uncore.c b/arch/x86/kernel/cpu/perf_event_intel_uncore.c
> index 812ec5d..2b0fa02 100644
> --- a/arch/x86/kernel/cpu/perf_event_intel_uncore.c
> +++ b/arch/x86/kernel/cpu/perf_event_intel_uncore.c
> @@ -883,6 +883,9 @@ static int __init uncore_pci_init(void)
>         case 62: /* Ivy Bridge-EP */
>                 ret = ivbep_uncore_pci_init();
>                 break;
> +       case 63: /* Haswell-EP */
> +               ret = hswep_uncore_pci_init();
> +               break;

my E5-1630 v3 crashes hard during boot in
snbep_uncore_msr_init_box()+0x3c
I don't have a setup to capture the screen so early in the boot.
So this is just heads up.
I replaced the call above with 'return -ENODEV' as a workaround.
btw, E5-16xx v3 became available just a month ago.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/