linux-kernel - Re: [PATCH 1/4] (CMA_AGGRESSIVE) Add CMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <2c27ad87839b42ca85c03c9541550d30@cnbox4.mioffice.cn>
Date:	Wed, 22 Oct 2014 05:44:24 +0000
From:	朱辉 <zhuhui@...omi.com>
To:	Pavel Machek <pavel@...x.de>
CC:	"rjw@...ysocki.net" <rjw@...ysocki.net>,
	"len.brown@...el.com" <len.brown@...el.com>,
	"m.szyprowski@...sung.com" <m.szyprowski@...sung.com>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"mina86@...a86.com" <mina86@...a86.com>,
	"aneesh.kumar@...ux.vnet.ibm.com" <aneesh.kumar@...ux.vnet.ibm.com>,
	"iamjoonsoo.kim@....com" <iamjoonsoo.kim@....com>,
	"hannes@...xchg.org" <hannes@...xchg.org>,
	"riel@...hat.com" <riel@...hat.com>,
	"mgorman@...e.de" <mgorman@...e.de>,
	"minchan@...nel.org" <minchan@...nel.org>,
	"nasa4836@...il.com" <nasa4836@...il.com>,
	"ddstreet@...e.org" <ddstreet@...e.org>,
	"hughd@...gle.com" <hughd@...gle.com>,
	"mingo@...nel.org" <mingo@...nel.org>,
	"rientjes@...gle.com" <rientjes@...gle.com>,
	"peterz@...radead.org" <peterz@...radead.org>,
	"keescook@...omium.org" <keescook@...omium.org>,
	"atomlin@...hat.com" <atomlin@...hat.com>,
	"raistlin@...ux.it" <raistlin@...ux.it>,
	"axboe@...com" <axboe@...com>,
	"paulmck@...ux.vnet.ibm.com" <paulmck@...ux.vnet.ibm.com>,
	"kirill.shutemov@...ux.intel.com" <kirill.shutemov@...ux.intel.com>,
	"n-horiguchi@...jp.nec.com" <n-horiguchi@...jp.nec.com>,
	"k.khlebnikov@...sung.com" <k.khlebnikov@...sung.com>,
	"msalter@...hat.com" <msalter@...hat.com>,
	"deller@....de" <deller@....de>,
	"tangchen@...fujitsu.com" <tangchen@...fujitsu.com>,
	"ben@...adent.org.uk" <ben@...adent.org.uk>,
	"akinobu.mita@...il.com" <akinobu.mita@...il.com>,
	"lauraa@...eaurora.org" <lauraa@...eaurora.org>,
	"vbabka@...e.cz" <vbabka@...e.cz>,
	"sasha.levin@...cle.com" <sasha.levin@...cle.com>,
	"vdavydov@...allels.com" <vdavydov@...allels.com>,
	"suleiman@...gle.com" <suleiman@...gle.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>
Subject: Re: [PATCH 1/4] (CMA_AGGRESSIVE) Add CMA_AGGRESSIVE to Kconfig



On 10/22/14 09:27, Pavel Machek wrote:
> Hi!
>
>> Add CMA_AGGRESSIVE config that depend on CMA to Linux kernel config.
>> Add CMA_AGGRESSIVE_PHY_MAX, CMA_AGGRESSIVE_FREE_MIN and CMA_AGGRESSIVE_SHRINK
>> that depend on CMA_AGGRESSIVE.
>>
>> If physical memory size (not include CMA memory) in byte less than or equal to
>> CMA_AGGRESSIVE_PHY_MAX, CMA aggressive switch (sysctl vm.cma-aggressive-switch)
>> will be opened.
>
> Ok...
>
> Do I understand it correctly that there is some problem with
> hibernation not working on machines not working on machines with big
> CMA areas...?

No, these patches want to handle this issue that most of CMA memory is 
not allocated before lowmemorykiller or oom_killer begin to kill tasks.

>
> But adding 4 config options end-user has no chance to set right can
> not be the best solution, can it?
>
>> +config CMA_AGGRESSIVE_PHY_MAX
>> +	hex "Physical memory size in Bytes that auto turn on the CMA aggressive switch"
>> +	depends on CMA_AGGRESSIVE
>> +	default 0x40000000
>> +	help
>> +	  If physical memory size (not include CMA memory) in byte less than or
>> +	  equal to this value, CMA aggressive switch will be opened.
>> +	  After the Linux boot, sysctl "vm.cma-aggressive-switch" can control
>> +	  the CMA AGGRESSIVE switch.
>
> For example... how am I expected to figure right value to place here?

I agree with that.  I will update this config to auto set in next version.

Thanks,
Hui

>
> 									Pavel
>