linux-kernel - Re: [PATCH 1/1] perf tool: add hists_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141022192933.GB14687@kernel.org>
Date:	Wed, 22 Oct 2014 16:29:33 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	kan.liang@...el.com
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] perf tool: add hists__init for perf diff

Em Wed, Oct 22, 2014 at 03:02:41PM -0400, kan.liang@...el.com escreveu:
> From: Kan Liang <kan.liang@...el.com>
> 
> perf diff also uses hists/hist_entries, hists__init() should be called
> before creating any evsels.

Thanks, this one merits perf/urgent :-\

- Arnaldo
 
> Signed-off-by: Kan Liang <kan.liang@...el.com>
> ---
>  tools/perf/builtin-diff.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c
> index 8c5c11c..25114c9 100644
> --- a/tools/perf/builtin-diff.c
> +++ b/tools/perf/builtin-diff.c
> @@ -1142,6 +1142,11 @@ static int data_init(int argc, const char **argv)
>  
>  int cmd_diff(int argc, const char **argv, const char *prefix __maybe_unused)
>  {
> +	int ret = hists__init();
> +
> +	if (ret < 0)
> +		return ret;
> +
>  	perf_config(perf_default_config, NULL);
>  
>  	argc = parse_options(argc, argv, options, diff_usage, 0);
> -- 
> 1.8.3.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/