linux-kernel - Re: [PATCH v2] drivers: net: xgene: Rewrite loop in xgene_enet_ecc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20141022.153436.93475594748933547.davem@davemloft.net>
Date:	Wed, 22 Oct 2014 15:34:36 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	geert@...ux-m68k.org
Cc:	isubramanian@....com, kchudgar@....com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] drivers: net: xgene: Rewrite loop in
 xgene_enet_ecc_init()

From: Geert Uytterhoeven <geert@...ux-m68k.org>
Date: Wed, 22 Oct 2014 09:39:41 +0200

> drivers/net/ethernet/apm/xgene/xgene_enet_sgmac.c: In function ‘xgene_enet_ecc_init’:
> drivers/net/ethernet/apm/xgene/xgene_enet_sgmac.c:126: warning: ‘data’ may be used uninitialized in this function
> 
> Depending on the arbitrary value on the stack, the loop may terminate
> too early, and cause a bogus -ENODEV failure.
> 
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> ---
> v2: Rewrite the loop instead of pre-initializing data.

I hate to be a pest, but like the other patch of your's I think
a do { } while() works best here because the intent is clearly
to run the loop at least once, right?