lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 22 Oct 2014 12:49:30 -0700 From: Andrew Morton <akpm@...ux-foundation.org> To: Dominik Dingel <dingel@...ux.vnet.ibm.com> Cc: linux-mm@...ck.org, Mel Gorman <mgorman@...e.de>, Michal Hocko <mhocko@...e.cz>, Paolo Bonzini <pbonzini@...hat.com>, Dave Hansen <dave.hansen@...el.com>, Rik van Riel <riel@...hat.com>, Andrea Arcangeli <aarcange@...hat.com>, Andy Lutomirski <luto@...capital.net>, "Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>, Bob Liu <lliubbo@...il.com>, Christian Borntraeger <borntraeger@...ibm.com>, Cornelia Huck <cornelia.huck@...ibm.com>, Gleb Natapov <gleb@...nel.org>, Heiko Carstens <heiko.carstens@...ibm.com>, "H. Peter Anvin" <hpa@...ux.intel.com>, Hugh Dickins <hughd@...gle.com>, Ingo Molnar <mingo@...nel.org>, Jianyu Zhan <nasa4836@...il.com>, Johannes Weiner <hannes@...xchg.org>, "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>, kvm@...r.kernel.org, linux390@...ibm.com, linux-kernel@...r.kernel.org, linux-s390@...r.kernel.org, Martin Schwidefsky <schwidefsky@...ibm.com>, Peter Zijlstra <peterz@...radead.org>, Sasha Levin <sasha.levin@...cle.com> Subject: Re: [PATCH 2/4] mm: introduce mm_forbids_zeropage function On Wed, 22 Oct 2014 21:45:52 +0200 Dominik Dingel <dingel@...ux.vnet.ibm.com> wrote: > > > +#ifndef mm_forbids_zeropage > > > +#define mm_forbids_zeropage(X) (0) > > > +#endif > > > > Can we document this please? What it does, why it does it. We should > > also specify precisely which arch header file is responsible for > > defining mm_forbids_zeropage. > > > > I will add a comment like: > > /* > * To prevent common memory management code establishing > * a zero page mapping on a read fault. > * This function should be implemented within <asm/pgtable.h>. s/function should be implemented/macro should be defined/ > * s390 does this to prevent multiplexing of hardware bits > * related to the physical page in case of virtualization. > */ > > Okay? Looks great, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists